Conversation
|
👋 Welcome back rbrchen! A progress list of the required criteria for merging this PR into |
|
@rbrchen This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 4 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. As you do not have Committer status in this project an existing Committer must agree to sponsor your change. ➡️ To flag this PR as ready for integration with the above commit message, type |
openjdk
bot
added
ready
Webrevs
|
| if (invokeOp != null) return invokeOp.result(); | ||
| if (invokeOp != null) { | ||
| return invokeOp.result(); | ||
| } |
There was a problem hiding this comment.
If this is null what do we return? Maybe we dont expect this ever to be the case. In which case shoudl we throw?
| @@ -123,10 +127,14 @@ private static Value getRootValue(Op op) { | |||
| } | |||
| case JavaOp.InvokeOp invokeOp -> { | |||
There was a problem hiding this comment.
All of this would be easier I think if you used the Invoke wrapper.
2 participants
Delete and refactor unnecessary buffer tagging code.
Also remove the @reflect annotation on S32Array::arrayView - this makes the buffer tagging break.
Progress
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/babylon.git pull/984/head:pull/984$ git checkout pull/984Update a local copy of the PR:
$ git checkout pull/984$ git pull https://git.openjdk.org/babylon.git pull/984/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 984View PR using the GUI difftool:
$ git pr show -t 984Using diff file
Download this PR as a diff file:
https://git.openjdk.org/babylon/pull/984.diff
Using Webrev
Link to Webrev Comment